Hi Linus, On Thu, Jul 08, 2021 at 01:43:14AM +0200, Linus Walleij wrote: > This adds device tree bindings for the Samsung Mobile Displays > LMS380KF01 RGB DPI display panel. > > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: phone-devel@xxxxxxxxxxxxxxx > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Cc: Noralf Trønnes <noralf@xxxxxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > ChangeLog v2->v3: > - No changes just resending with the series. > ChangeLog v1->v2: > - Expect SPI bindings to be pulled in for the client and state > spi-cpha: true etc. > - Make port a required node. > - Update the example to use a proper SPI controller (spi-gpio) > so we get full validation of the example. > --- > .../display/panel/samsung,lms380kf01.yaml | 97 +++++++++++++++++++ > 1 file changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml b/Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml > new file mode 100644 > index 000000000000..ebc33c36c124 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/samsung,lms380kf01.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung LMS380KF01 display panel > + > +description: The LMS380KF01 is a 480x800 DPI display panel from Samsung Mobile > + Displays (SMD) utilizing the WideChips WS2401 display controller. It can be > + used with internal or external backlight control. Other bindings using spi properties has the followign text: The panel must obey the rules for a SPI slave device as specified in spi/spi-controller.yaml Maybe add this here? > + > +maintainers: > + - Linus Walleij <linus.walleij@xxxxxxxxxx> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: samsung,lms380kf01 > + > + reg: true > + > + interrupts: > + description: provides an optional ESD (electrostatic discharge) > + interrupt that signals abnormalities in the display hardware. > + This can also be raised for other reasons like erroneous > + configuration. > + maxItems: 1 > + > + reset-gpios: true > + > + vci-supply: > + description: regulator that supplies the VCI analog voltage > + usually around 3.0 V > + > + vccio-supply: > + description: regulator that supplies the VCCIO voltage usually > + around 1.8 V > + > + backlight: true > + > + spi-cpha: true > + > + spi-cpol: true > + > + spi-max-frequency: > + maximum: 1200000 > + > + port: true > + > +required: > + - compatible > + - reg > + - spi-cpha > + - spi-cpol > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + spi { > + compatible = "spi-gpio"; > + sck-gpios = <&gpio 0 GPIO_ACTIVE_HIGH>; > + miso-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>; > + mosi-gpios = <&gpio 2 GPIO_ACTIVE_HIGH>; > + cs-gpios = <&gpio 3 GPIO_ACTIVE_HIGH>; > + num-chipselects = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + Most panel/samsung* bindings uses 4 spaces indent. > + panel@0 { > + compatible = "samsung,lms380kf01"; > + spi-max-frequency = <1200000>; > + spi-cpha; > + spi-cpol; > + reg = <0>; > + vci-supply = <&lcd_3v0_reg>; > + vccio-supply = <&lcd_1v8_reg>; > + reset-gpios = <&gpio 4 GPIO_ACTIVE_LOW>; > + interrupt-parent = <&gpio>; > + interrupts = <5 IRQ_TYPE_EDGE_RISING>; > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&display_out>; > + }; > + }; > + }; > + }; > + > +... Whith my commnets considered (but not necessary followed): Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
