On Fri, Jul 9, 2021 at 11:25 AM Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote: > > + /* Assert reset >=1 ms */ > > + gpiod_set_value_cansleep(ws->reset, 1); > > + usleep_range(1000, 5000); > > + /* De-assert reset */ > > + gpiod_set_value_cansleep(ws->reset, 0); > > + /* Wait >= 10 ms */ > > + msleep(10); > > + dev_dbg(ws->dev, "de-asserted RESET\n"); > > Just a small comment, are these delays are as per init sequence > mentioned in datasheet? As so often with Samsung mobile displays there is no datasheet. These delays are in the product source code tree for the GT-I8160 (Codina) mobile phone, actually in the glue integration code. WideChips were acquired by some other firm and do not exist anymore so I can't ask them, and asking Samsung for anything else than source code doesn't work either. (I have tried.) Yours, Linus Walleij