Re: [PATCH v2] drm/dbi: Print errors for mipi_dbi_command()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 02, 2021 at 12:27:42PM +0200, Sam Ravnborg wrote:
> On Fri, Jul 02, 2021 at 12:04:55PM +0200, Linus Walleij wrote:
> > The macro mipi_dbi_command() does not report errors unless you wrap it
> > in another macro to do the error reporting.
> > 
> > Report a rate-limited error so we know what is going on.
> > 
> > Drop the only user in DRM using mipi_dbi_command() and actually checking
> > the error explicitly, let it use mipi_dbi_command_buf() directly
> > instead.
> > 
> > After this any code wishing to send command arrays can rely on
> > mipi_dbi_command() providing an appropriate error message if something
> > goes wrong.
> > 
> > Suggested-by: Noralf Trønnes <noralf@xxxxxxxxxxx>
> > Suggested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Too fast send, this should read:
Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux