On Mon, Jun 28, 2021 at 11:30 AM Noralf Trønnes <noralf@xxxxxxxxxxx> wrote: > > + dev_info(ws->dev, "MTP ID: %02x %02x %02x\n", id1, id2, id3); > > +} > > Why do you read these id's on every power on, it doesn't look like you > use them? > > If they're just informational, they should be available through debugfs, > see mipi_dbi_debugfs_init(). I moved them to probe. I actually really want to print this into dmesg so we learn to understand these MTP values better, if for nothing else so for the fact that they will turn up in google searches. The actual display controller vendor comes out in the first MTP byte, and by collecting this data we can figure out to some extent what kind of hardware is actually inside some of these displays. In this case 0xDA is 0x40 so that is widechips manufacturer ID. I fixed the rest of the comments! Yours, Linus Walleij
