答复: [PATCH v2 02/22] drm/hibmc: Call drm_irq_uninstall() unconditionally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




-----邮件原件-----
发件人: Thomas Zimmermann [mailto:tzimmermann@xxxxxxx] 
发送时间: 2021年6月22日 22:10
收件人: daniel@xxxxxxxx; airlied@xxxxxxxx; alexander.deucher@xxxxxxx; christian.koenig@xxxxxxx; Xinhui.Pan@xxxxxxx; james.qian.wang@xxxxxxx; liviu.dudau@xxxxxxx; mihail.atanassov@xxxxxxx; brian.starkey@xxxxxxx; maarten.lankhorst@xxxxxxxxxxxxxxx; mripard@xxxxxxxxxx; inki.dae@xxxxxxxxxxx; jy0922.shim@xxxxxxxxxxx; sw0312.kim@xxxxxxxxxxx; kyungmin.park@xxxxxxxxxxx; krzysztof.kozlowski@xxxxxxxxxxxxx; xinliang.liu@xxxxxxxxxx; tiantao (H) <tiantao6@xxxxxxxxxxxxx>; john.stultz@xxxxxxxxxx; kongxinwei (A) <kong.kongxinwei@xxxxxxxxxxxxx>; Chenfeng (puck) <puck.chen@xxxxxxxxxxxxx>; laurentiu.palcu@xxxxxxxxxxx; l.stach@xxxxxxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; linux-imx@xxxxxxx; chunkuang.hu@xxxxxxxxxx; matthias.bgg@xxxxxxxxx; bskeggs@xxxxxxxxxx; tomba@xxxxxxxxxx; hjc@xxxxxxxxxxxxxx; heiko@xxxxxxxxx; benjamin.gaignard@xxxxxxxxxx; yannick.fertre@xxxxxxxxxxx; philippe.cornu@xxxxxxxxxxx; mcoquelin.stm32@xxxxxxxxx; alexandre.torgue@xxxxxxxxxxx; wens@xxxxxxxx; jernej.skrabec@xxxxxxxxx; thierry.reding@xxxxxxxxx; jonathanh@xxxxxxxxxx; jyri.sarha@xxxxxx; emma@xxxxxxxxxx; linux-graphics-maintainer@xxxxxxxxxx; zackr@xxxxxxxxxx; hyun.kwon@xxxxxxxxxx; laurent.pinchart@xxxxxxxxxxxxxxxx; michal.simek@xxxxxxxxxx
抄送: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; nouveau@xxxxxxxxxxxxxxxxxxxxx; linux-rockchip@xxxxxxxxxxxxxxxxxxx; linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx; linux-sunxi@xxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; Thomas Zimmermann <tzimmermann@xxxxxxx>
主题: [PATCH v2 02/22] drm/hibmc: Call drm_irq_uninstall() unconditionally

Remove the check around drm_irq_uninstall(). The same test is done by the function internally. The tested state in irq_enabled is considered obsolete and should not be used by KMS drivers.

Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Tian Tao <tiantao6@xxxxxxxxxxxxx>

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index f4bc5386574a..f8ef711bbe5d 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -253,8 +253,7 @@ static int hibmc_unload(struct drm_device *dev)  {
 	drm_atomic_helper_shutdown(dev);
 
-	if (dev->irq_enabled)
-		drm_irq_uninstall(dev);
+	drm_irq_uninstall(dev);
 
 	pci_disable_msi(to_pci_dev(dev->dev));
 
--
2.32.0





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux