On Mon, 21 Jun 2021 15:34:35 +0100 Steven Price <steven.price@xxxxxxx> wrote: > On 21/06/2021 14:38, Boris Brezillon wrote: > > Exception types will be defined as an enum in panfrost_drm.h so userspace > > and use the same definitions if needed. > > s/and/can/ ? > > While it is (currently) unused in the kernel, this is a hardware value > so I'm not sure why it's worth removing this and not the other > (currently) unused values here. This is the value returned from the > JS_STATUS register when the slot is actively processing a job. Hm, what's the point of having the same value defined in 2 places (DRM_PANFROST_EXCEPTION_ACTIVE defined in patch 3 vs JS_STATUS_EVENT_ACTIVE here)? I mean, values defined in the drm_panfrost_exception_type enum apply to the JS_STATUS registers too, right? > > Steve > > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > > --- > > drivers/gpu/drm/panfrost/panfrost_regs.h | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_regs.h b/drivers/gpu/drm/panfrost/panfrost_regs.h > > index dc9df5457f1c..1940ff86e49a 100644 > > --- a/drivers/gpu/drm/panfrost/panfrost_regs.h > > +++ b/drivers/gpu/drm/panfrost/panfrost_regs.h > > @@ -262,9 +262,6 @@ > > #define JS_COMMAND_SOFT_STOP_1 0x06 /* Execute SOFT_STOP if JOB_CHAIN_FLAG is 1 */ > > #define JS_COMMAND_HARD_STOP_1 0x07 /* Execute HARD_STOP if JOB_CHAIN_FLAG is 1 */ > > > > -#define JS_STATUS_EVENT_ACTIVE 0x08 > > - > > - > > /* MMU regs */ > > #define MMU_INT_RAWSTAT 0x2000 > > #define MMU_INT_CLEAR 0x2004 > > >
