Re: [PATCH -next] drm/hyperv: Remove unused variable

[Pu Lehui <pulehui@xxxxxxxxxx>]

On 2021/6/9 15:46, Thomas Zimmermann wrote:
> Hi
>
> Am 09.06.21 um 04:49 schrieb Pu Lehui:
> > Fixes gcc '-Wunused-const-variable' warning:
> >    drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
> >      'hyperv_modifiers' defined but not used [-Wunused-const-variable=]
> >
> > Signed-off-by: Pu Lehui <pulehui@xxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 -----
> >   1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c 
> > b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> > index 02718e3e859e..3f83493909e6 100644
> > --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> > +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> > @@ -149,11 +149,6 @@ static const uint32_t hyperv_formats[] = {
> >       DRM_FORMAT_XRGB8888,
> >   };
> > -static const uint64_t hyperv_modifiers[] = {
> > -    DRM_FORMAT_MOD_LINEAR,
> > -    DRM_FORMAT_MOD_INVALID
> > -};
>
> This constant should rather be used in the call to 
> drm_simple_display_pipe_init(). [1]
>
> Best regards
> Thomas
>
> [1] 
> https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c#n161 
>
>
>
> > -
> >   static inline int hyperv_pipe_init(struct hyperv_drm_device *hv)
> >   {
> >       int ret;
Hi Thomas,

Thanks for your suggestion, I will fix it in v2.

Best regards
Lehui