On Fri, Jun 11, 2021 at 12:42 AM Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> On Thu, Jun 10, 2021 at 3:39 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > #define mipi_dbi_command(dbi, cmd, seq...) \
> > ({ \
> > const u8 d[] = { seq }; \
> > mipi_dbi_command_stackbuf(dbi, cmd, d, ARRAY_SIZE(d)); \
> > })
> >
> > I'll fix up the include and apply then we can think about
> > what to do with mipi_dbi_command().
>
> Are you sure that doesn't work? Isn't the return value of a macro the
> last expression? In this case the return value of
> mipi_dbi_command_stackbuf() should just flow through.
w00t I didn't know that.
And I like to think of the macro processor as essentially just
inserting the content of the macro at the cursor.
But arguably it *should* rather be fixed in this macro though?
It is used in the same way in all other drivers as well.
Yours,
Linus Walleij
