Re: [PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 11, 2021 at 12:42 AM Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> On Thu, Jun 10, 2021 at 3:39 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:


> > #define mipi_dbi_command(dbi, cmd, seq...) \
> > ({ \
> >         const u8 d[] = { seq }; \
> >         mipi_dbi_command_stackbuf(dbi, cmd, d, ARRAY_SIZE(d)); \
> > })
> >
> > I'll fix up the include and apply then we can think about
> > what to do with mipi_dbi_command().
>
> Are you sure that doesn't work? Isn't the return value of a macro the
> last expression? In this case the return value of
> mipi_dbi_command_stackbuf() should just flow through.

w00t I didn't know that.

And I like to think of the macro processor as essentially just
inserting the content of the macro at the cursor.

But arguably it *should* rather be fixed in this macro though?
It is used in the same way in all other drivers as well.

Yours,
Linus Walleij



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux