Re: [PATCH v4] drm/panel: db7430: Add driver for Samsung DB7430

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Noralf,

thanks for the review. Doug poked me with something sharp
until I finally complied and started to use the DBI library.
Now I have to convert the other 9bpw DBI type displays
I have.

On Thu, Jun 10, 2021 at 6:15 PM Noralf Trønnes <noralf@xxxxxxxxxxx> wrote:

> > +     /** @reset: reset GPIO line */
> > +     struct gpio_desc *reset;
>
> You can use dbi->reset.

I fixed all except this: it just feels weird to use the struct mipi_dbi for
storing the reset without the DBI core making any operations on it,
I think this and the regulator should possibly be moved over to
struct mipi_dbi_dev where the regulator is.

Yours,
Linus Walleij




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux