Re: [PATCH 0/4] drm: add per-connector hotplug events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 09, 2021 at 10:39:03AM +0000, Simon Ser wrote:
> When a uevent only updates a single connector, add a CONNECTOR property
> to the uevent. This allows user-space to ignore other connectors when
> handling the uevent. This is purely an optimization, drivers can still
> send a uevent without the CONNECTOR property.
> 
> The CONNECTOR property is already set when sending HDCP property update
> uevents, see drm_sysfs_connector_status_event.
> 
> This has been tested with a wlroots patch [1].
> 
> amdgpu has been updated to use these new fine-grained uevents.

That's a bit thin for motivating roll-out ... Also my idea was that with
the per-connector epoch counter we could make this happen for anyone using
the probe helpers.

I also thought that the dp hotplug code was a bit more unified by now to
not need the duplication across all drivers. But there's only three for
that.

Ofc drivers that hand-roll their hpd code need to be adjusted, but I've
hoped that with the epoch counter we could just make the current hotplug
event code dtrt thing here automatically maybe?

Consistent kms interface across drivers is good, and I think we should
aim for that.
-Daniel

> 
> [1]: https://github.com/swaywm/wlroots/pull/2959
> 
> Simon Ser (4):
>   drm/sysfs: introduce drm_sysfs_connector_hotplug_event
>   drm/probe-helper: add drm_kms_helper_connector_hotplug_event
>   drm/connector: use drm_sysfs_connector_hotplug_event
>   amdgpu: use drm_kms_helper_connector_hotplug_event
> 
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  8 +++---
>  .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |  4 +--
>  drivers/gpu/drm/drm_connector.c               |  2 +-
>  drivers/gpu/drm/drm_probe_helper.c            | 20 +++++++++++++++
>  drivers/gpu/drm/drm_sysfs.c                   | 25 +++++++++++++++++++
>  include/drm/drm_probe_helper.h                |  1 +
>  include/drm/drm_sysfs.h                       |  1 +
>  7 files changed, 54 insertions(+), 7 deletions(-)
> 
> -- 
> 2.31.1
> 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux