Re: [Intel-gfx] [PATCH 24/31] drm/i915/gem: Delay context creation (v2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jason,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.13-rc5 next-20210608]
[cannot apply to drm-intel/for-linux-next drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/7e9cc2833847aeb50a05f0a5e35282792514b5f1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926
        git checkout 7e9cc2833847aeb50a05f0a5e35282792514b5f1
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gem/i915_gem_context.c:2533:1: warning: no previous prototype for 'finalize_create_context_locked' [-Wmissing-prototypes]
    2533 | finalize_create_context_locked(struct drm_i915_file_private *file_priv,
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/finalize_create_context_locked +2533 drivers/gpu/drm/i915/gem/i915_gem_context.c

  2531	
  2532	struct i915_gem_context *
> 2533	finalize_create_context_locked(struct drm_i915_file_private *file_priv,
  2534				       struct i915_gem_proto_context *pc, u32 id)
  2535	{
  2536		struct i915_gem_context *ctx;
  2537		void *old;
  2538	
  2539		lockdep_assert_held(&file_priv->proto_context_lock);
  2540	
  2541		ctx = i915_gem_create_context(file_priv->dev_priv, pc);
  2542		if (IS_ERR(ctx))
  2543			return ctx;
  2544	
  2545		gem_context_register(ctx, file_priv, id);
  2546	
  2547		old = xa_erase(&file_priv->proto_context_xa, id);
  2548		GEM_BUG_ON(old != pc);
  2549		proto_context_close(pc);
  2550	
  2551		/* One for the xarray and one for the caller */
  2552		return i915_gem_context_get(ctx);
  2553	}
  2554	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux