Hi, On Fri, Jun 4, 2021 at 4:19 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Tue, Jun 1, 2021 at 11:31 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > > Still hoping that this can work atop DBI so we can avoid the raw SPI > > writes. You said you're trying for it for v3 so I'm looking forward to > > checking it out there. > > Struggling with this. The DBI bus is only used by tiny DRM > for the panel drivers that are jitted with that display controller > ATM. No normal panel driver is using it. :( So how about this, then? * If someone more senior than me in DRM says it's fine to just do this directly for now then I have no objections. It'd be nice to mention that this is actually DBI "type c1" somewhere in the comments, but other than that the direct SPI stuff is OK. * If there are 3+ other panels drivers that you can point to that directly use SPI functions for DBI like you are doing then I'm OK w/ it too even if nobody more senior signs on w/ it. Presumably if there are at least 3 already then someone else has already signed on to the fact that this is fine to do. It'd still be nice to do a cleanup but presumably that could all be done at the same time. * If you're the first or second or third panel driver that's doing this directly with SPI commands then it probably makes sense to pause and figure out how to use DBI right now before more drivers come around and copy the code. Hopefully that sounds OK. -Doug
