>> +
>> +maintainers:
>> + - Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
>> +
>> +description: |+
> Do you need the formatting? If not, drop '|+'.
I'm not sure whether I do, so I guess dropping it is fine.
>> + This panel seems to only be found in SONY Xperia
>> + X, X Performance, X Compact, XZ and XZs
>> + smartphones and we have no straightforward way of
>> + actually getting the correct model number,
>> + as no schematics are released publicly.
> Odd choice of line break length. 80 char please.
Right.
>> +
>> + preset-gpio:
>> + description: panel reset pin
> What's reset-gpios then?
reset-gpios is an overlook on my side :)
>> +
>> + pvddio-gpio:
>> + description: panel vddio pin
>> +
>> + treset-gpio:
>> + description: touch reset pin
> Use '-gpios'
>
> And need to define how many (maxItems: 1).
Right.
>> + #include <dt-bindings/gpio/gpio.h>
>> +
>> + dsi {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + panel: panel@0 {
>> + reg = <0>;
>> +
>> + pvddio-gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>;
>> + preset-gpio = <&tlmm 8 GPIO_ACTIVE_HIGH>;
>> + treset-gpio = <&tlmm 89 GPIO_ACTIVE_HIGH>;
>> +
>> + vddio-supply = <&pm8994_s4>;
>> + avdd-supply = <&pm8994_l2>;
>> + tvdd-supply = <&panel_tvdd>;
>> +
>> + backlight = <&pmi8994_wled>;
>> +
>> + port {
>> + panel_in: endpoint {
>> + remote-endpoint = <&dsi0_out>;
>> + };
> Consistent indentation please. 4 spaces is good.
Another mistake, ack.
I'll send a v2 shortly.
Konrad
