Re: [PATCH V5 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc4 next-20210603]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Marek-Vasut/dt-bindings-drm-bridge-ti-sn65dsi83-Add-TI-SN65DSI83-and-SN65DSI84-bindings/20210603-045141
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: riscv-randconfig-r021-20210604 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5c0d1b2f902aa6a9cf47cc7e42c5b83bb2217cf9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/98230a7ee966724a2b4bae97cb2f918c06fb2506
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Marek-Vasut/dt-bindings-drm-bridge-ti-sn65dsi83-Add-TI-SN65DSI83-and-SN65DSI84-bindings/20210603-045141
        git checkout 98230a7ee966724a2b4bae97cb2f918c06fb2506
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/bridge/ti-sn65dsi83.c:642:11: warning: cast to smaller integer type 'enum sn65dsi83_model' from 'const void *' [-Wvoid-pointer-to-enum-cast]
                   model = (enum sn65dsi83_model)of_device_get_match_data(dev);
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for LOCKDEP
   Depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && (FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86)
   Selected by
   - PROVE_LOCKING && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
   - DEBUG_LOCK_ALLOC && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT


vim +642 drivers/gpu/drm/bridge/ti-sn65dsi83.c

   626	
   627	static int sn65dsi83_probe(struct i2c_client *client,
   628				   const struct i2c_device_id *id)
   629	{
   630		struct device *dev = &client->dev;
   631		enum sn65dsi83_model model;
   632		struct sn65dsi83 *ctx;
   633		int ret;
   634	
   635		ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
   636		if (!ctx)
   637			return -ENOMEM;
   638	
   639		ctx->dev = dev;
   640	
   641		if (dev->of_node)
 > 642			model = (enum sn65dsi83_model)of_device_get_match_data(dev);
   643		else
   644			model = id->driver_data;
   645	
   646		ctx->enable_gpio = devm_gpiod_get(ctx->dev, "enable", GPIOD_OUT_LOW);
   647		if (IS_ERR(ctx->enable_gpio))
   648			return PTR_ERR(ctx->enable_gpio);
   649	
   650		ret = sn65dsi83_parse_dt(ctx, model);
   651		if (ret)
   652			return ret;
   653	
   654		ctx->regmap = devm_regmap_init_i2c(client, &sn65dsi83_regmap_config);
   655		if (IS_ERR(ctx->regmap))
   656			return PTR_ERR(ctx->regmap);
   657	
   658		dev_set_drvdata(dev, ctx);
   659		i2c_set_clientdata(client, ctx);
   660	
   661		ctx->bridge.funcs = &sn65dsi83_funcs;
   662		ctx->bridge.of_node = dev->of_node;
   663		drm_bridge_add(&ctx->bridge);
   664	
   665		return 0;
   666	}
   667	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux