On Wed, 2 Jun 2021 20:18:19 +0000 "Shankar, Uma" <uma.shankar@xxxxxxxxx> wrote: > > -----Original Message----- > > From: Pekka Paalanen <ppaalanen@xxxxxxxxx> > > Sent: Wednesday, June 2, 2021 2:40 PM > > To: Shankar, Uma <uma.shankar@xxxxxxxxx> > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Modem, > > Bhanuprakash <bhanuprakash.modem@xxxxxxxxx> > > Subject: Re: [PATCH 1/9] drm: Add gamma mode property > > > > On Tue, 1 Jun 2021 16:11:27 +0530 > > Uma Shankar <uma.shankar@xxxxxxxxx> wrote: > > > > > Add a gamma mode property to enable various kind of gamma modes > > > supported by platforms like: Interpolated, Split, Multi Segmented, > > > Logarithmic etc. Userspace can get this property and should be able to > > > get the platform capabilities wrt various gamma modes possible and the > > > possible ranges. > > > > > > It can select one of the modes exposed as blob_id as an enum and set > > > the respective mode. > > > > > > It can then create the LUT and send it to driver using already > > > available GAMMA_LUT property as blob. > > > > > > Note: This is based on design by Ville and is being carried forward > > > based on his original idea. > > > > > > Signed-off-by: Uma Shankar <uma.shankar@xxxxxxxxx> > > > --- > > > drivers/gpu/drm/drm_atomic_uapi.c | 5 +++ > > > drivers/gpu/drm/drm_color_mgmt.c | 75 +++++++++++++++++++++++++++++++ > > > include/drm/drm_color_mgmt.h | 8 ++++ > > > include/drm/drm_crtc.h | 14 ++++++ > > > include/uapi/drm/drm_mode.h | 43 ++++++++++++++++++ > > > 5 files changed, 145 insertions(+) ... > > Hi, > > > > where is the UAPI documentation for this new GAMMA_MODE? > > As a userspace dev, I have no idea what to do with the above based on what's > > written here. > > Got that, I will add more details on the UAPI usage to make things a bit clearer. > > > Also, reading the description of DRM_CLIENT_CAP_ADVANCE_GAMMA_MODES in > > patch 5/9, what difference does it make whether userspace sets or does not set that > > cap? I don't understand the implications from the description. > > The reason we have this Client caps is to have it co-exist with legacy crtc color properties. > The idea is that driver will describe the h/w luts to userspace through GAMMA_MODE UAPI, > but the actual lut samples will still be sent through the legacy GAMMA_LUT UAPI. This client > cap will help distinguish between legacy and this new implementation. > > I will add more details in the UAPI description to avoid ambiguity and explain the rationale and > usage of this UAPI. > > Thanks Pekka for the looking into the series and the initial feedback. Thanks a lot, will be interesting to read those docs. pq
Attachment:
pgp3UuvgokZBa.pgp
Description: OpenPGP digital signature
