Re: [PATCH v8 03/11] dt-bindings: drm/bridge: ti-sn65dsi86: Add aux-bus child

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 28, 2021 at 02:29:53AM +0200, Linus Walleij wrote:
> On Tue, May 25, 2021 at 2:02 AM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> 
> > The patch ("dt-bindings: drm: Introduce the DP AUX bus") talks about
> > how using the DP AUX bus is better than learning how to slice
> > bread. Let's add it to the ti-sn65dsi86 bindings.
> >
> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> (...)
> >      description: See ../../pwm/pwm.yaml for description of the cell formats.>
> 
> Just use the full path:
> /schemas/pwm/pwm.yaml

Really, just drop it. If we want have generic references and/or 
descriptions for common properties, we should generate that in pretty 
documentation (there are json-schema to doc tools already).

> 
> > +  aux-bus:
> > +    $ref: ../dp-aux-bus.yaml#
> 
> Use the full path. (Same method as above)

+1

> This removes the need for ../../... ....
> 
> You do it here:
> 
> >    ports:
> >      $ref: /schemas/graph.yaml#/properties/ports
> 
> Other than that I think it looks all right!
> 
> Yours,
> Linus Walleij



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux