Hi Hans, What happened with this series, did it fall through the cracks? On Wed, 21 Apr 2021 at 21:48, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > --- /dev/null > +++ b/drivers/gpu/drm/drm_privacy_screen.c > +#include "drm_internal.h" I think we don't need this include, do we? > --- /dev/null > +++ b/include/drm/drm_privacy_screen_consumer.h > +#include <drm/drm_connector.h> Ditto > --- /dev/null > +++ b/include/drm/drm_privacy_screen_driver.h > +#include <drm/drm_connector.h> Ditto I like how you avoided leaking any DRM details within the new code, modulo the includes above. With above tweaks, the series is: Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx> Theoretically one could also remove the `depends on DRM` from patch 8/9 but I'm not sure how much that saves us. HTH -Emil
