Added r-b tag and merged to drm-misc next. https://cgit.freedesktop.org/drm/drm-misc/log/?h=drm-misc-next Thanks for the submission, and sorry about making you jump through all those hoops. On Mon, 31 May 2021 at 15:47, Yu Kuai <yukuai3@xxxxxxxxxx> wrote: > > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx> > --- > changes in V2: > - change error message. > > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > index 0cd8f40fb690..eab959a59214 100644 > --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > @@ -2478,9 +2478,9 @@ static int cdns_mhdp_probe(struct platform_device *pdev) > clk_prepare_enable(clk); > > pm_runtime_enable(dev); > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0) { > - dev_err(dev, "pm_runtime_get_sync failed\n"); > + dev_err(dev, "pm_runtime_resume_and_get failed\n"); > pm_runtime_disable(dev); > goto clk_disable; > } > -- > 2.31.1 >
