Am 2021-05-29 um 2:38 a.m. schrieb Christoph Hellwig: > On Thu, May 27, 2021 at 07:08:05PM -0400, Felix Kuehling wrote: >> diff --git a/kernel/resource.c b/kernel/resource.c >> index 627e61b0c124..da137553b83e 100644 >> --- a/kernel/resource.c >> +++ b/kernel/resource.c >> @@ -783,7 +783,7 @@ struct resource *lookup_resource(struct resource *root, resource_size_t start) >> >> return res; >> } >> - >> +EXPORT_SYMBOL(lookup_resource); > NAK on hiding random exports in a driver patch. This needs to be a proper > patch with a proper rationale, a kerneldoc comment and use > EXPORT_SYMBOL_GPL. And even then it smells rather fishy, but I'll wait > for the rationale. Yeah, I missed that in internal review. I agree this needs to be a separate patch. The rationale is, that the GPU driver needs to be able to look up and claim the resource corresponding to its VRAM in order to register it as DEVICE_GENERIC memory with devmap. If there is a better way to do this, I'm open to suggestions. Regards, Felix
