On 21-05-21, 17:29, Daniel Vetter wrote: > On Fri, May 21, 2021 at 06:19:30PM +0530, Vinod Koul wrote: > > We required a helper to create and set the dsc_dce_header, so add the > > dsc_dce_header and API drm_dsc_dsi_pps_header_init > > > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > > --- > > drivers/gpu/drm/drm_dsc.c | 11 +++++++++++ > > include/drm/drm_dsc.h | 16 ++++++++++++++++ > > 2 files changed, 27 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_dsc.c b/drivers/gpu/drm/drm_dsc.c > > index ff602f7ec65b..0c1b745090e2 100644 > > --- a/drivers/gpu/drm/drm_dsc.c > > +++ b/drivers/gpu/drm/drm_dsc.c > > @@ -49,6 +49,17 @@ void drm_dsc_dp_pps_header_init(struct dp_sdp_header *pps_header) > > } > > EXPORT_SYMBOL(drm_dsc_dp_pps_header_init); > > > > +void drm_dsc_dsi_pps_header_init(struct dsc_dce_header *dsc_header) > > Kerneldoc for anything exported to drivers please, also ideally for all > the structures. Sorry missed that, will add -- ~Vinod
