Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

On Sun, May 16, 2021 at 01:49:11AM +0200, Marek Vasut wrote:
> On 5/15/21 11:48 PM, Laurent Pinchart wrote:
> > Hi Marek,
> 
> Hi,
> 
> > Thank you for the patch.
> > 
> > On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
> >> Add missing spaces to make the diagrams readable, no functional change.
> > 
> > Looks better indeed. The patch view looks bad though, because of the
> > tabs. Maybe you could replace them with spaces, while at it ?
> 
> It is all spaces, where do you see tabs ?

Right after "Slot", "Clock" and "DATA[0123]". You're not touching those
lines, but having tabs there messes up the formatting of the patch
itself (the resulting bindings file looks good).

By the way, the subject line doesn't match the patch, you're modifying
panel/lvds.yaml, not bridge/lvds-codec.yaml.

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux