Re: [PATCH v15 2/4] dt-bindings: msm: dsi: add yaml schemas for DSI bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 5, 2021 at 11:11 PM <mkrishn@xxxxxxxxxxxxxx> wrote:
>
> On 2021-04-08 20:33, Rob Herring wrote:
> > On Mon, Apr 05, 2021 at 04:36:08PM +0530, Krishna Manikandan wrote:
> >> Add YAML schema for the device tree bindings for DSI

> >> +              data-lanes:
> >> +                $ref: "/schemas/media/video-interfaces.yaml#"
> >
> > Not how this reference works. Look at other examples.
> >
> >> +                description: |
> >> +                  This describes how the physical DSI data lanes are
> >> mapped
> >> +                  to the logical lanes on the given platform. The
> >> value contained in
> >> +                  index n describes what physical lane is mapped to
> >> the logical lane n
> >> +                  (DATAn, where n lies between 0 and 3). The clock
> >> lane position is fixed
> >> +                  and can't be changed. Hence, they aren't a part of
> >> the DT bindings.
> >> +
> >> +                items:
> >> +                  - const: 0
> >> +                  - const: 1
> >> +                  - const: 2
> >> +                  - const: 3
> >
> > If this is the only possible value, why does it need to be in DT?
> Hi Rob,
> These are the possible values:
> -    <0 1 2 3>
> -    <1 2 3 0>
> -    <2 3 0 1>
> -    <3 0 1 2>
> -    <0 3 2 1>
> -    <1 0 3 2>
> -    <2 1 0 3>
> -    <3 2 1 0>
>
> Shall I follow the below mentioned approach for defining these values ?
> oneOf:
>    - items:
>      - const: 0
>      - const: 1
>      - const: 2
>      - const: 3
>    - items:
>      - const: 1
>      - const: 2
>      - const: 3
>      - const: 0
>    - items:
>      - const: 2
>      - const: 3
>      - const: 0
>      - const: 1
>    - items:
>      - const: 3
>      - const: 0
>      - const: 1
>      - const: 2
>    - items:
>      - const: 0
>      - const: 3
>      - const: 2
>      - const: 1
>    - items:
>      - const: 1
>      - const: 0
>      - const: 3
>      - const: 2
>    - items:
>      - const: 2
>      - const: 1
>      - const: 0
>      - const: 3
>    - items:
>      - const: 3
>      - const: 2
>      - const: 1
>      - const: 0

That's too verbose.

maxItems: 4
minItems: 4 (or is less supported?)
items:
  enum: [ 0, 1, 2, 3 ]



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux