On Wed, May 05, 2021 at 12:02:17PM +0200, Marek Vasut wrote: > Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Cc: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > Cc: Stephen Boyd <swboyd@xxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > To: dri-devel@xxxxxxxxxxxxxxxxxxxxx > --- > V2: Add compatible string for SN65DSI84, since this is now tested on it > V3: - Add 0x2c as valid i2c address > - Switch to schemas/graph.yaml > - Constraint data-lanes to <1>, <1 2>, <1 2 3>, <1 2 3 4> only > - Indent example by 4 spaces > - Handle dual-link LVDS with two ports and describe the second DSI > channel-B port as well. Based on the register defaults of DSI83 > and DSI84, it is likely that the LVDS-channel-B and DSI-channel-B > hardware is present in all the chips, so just reuse port@0 and 2 > for DSI83, port@0,2,3 for DSI84 and all of 0,1,2,3 for DSI85 when > that is supported > --- > .../bindings/display/bridge/ti,sn65dsi83.yaml | 171 ++++++++++++++++++ > 1 file changed, 171 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > new file mode 100644 > index 000000000000..4e7df92446a9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > @@ -0,0 +1,171 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi83.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SN65DSI83 and SN65DSI84 DSI to LVDS bridge chip > + > +maintainers: > + - Marek Vasut <marex@xxxxxxx> > + > +description: | > + Texas Instruments SN65DSI83 1x Single-link MIPI DSI > + to 1x Single-link LVDS > + https://www.ti.com/lit/gpn/sn65dsi83 > + Texas Instruments SN65DSI84 1x Single-link MIPI DSI > + to 1x Dual-link or 2x Single-link LVDS > + https://www.ti.com/lit/gpn/sn65dsi84 > + > +properties: > + compatible: > + oneOf: > + - const: ti,sn65dsi83 > + - const: ti,sn65dsi84 Use 'enum' instead of oneOf+const. > + > + reg: > + oneOf: > + - const: 0x2c > + - const: 0x2d Ditto > + > + enable-gpios: > + maxItems: 1 > + description: GPIO specifier for bridge_en pin (active high). > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Video port for MIPI DSI Channel-A input > + > + properties: > + endpoint: > + $ref: /schemas/graph.yaml#/$defs/endpoint-base This should actually be video-interfaces.yaml since you use one of the properties from it. > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: array of physical DSI data lane indexes. > + minItems: 1 > + maxItems: 4 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Video port for MIPI DSI Channel-B input > + > + properties: > + endpoint: > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: array of physical DSI data lane indexes. > + minItems: 1 > + maxItems: 4 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + > + port@2: > + $ref: /schemas/graph.yaml#/properties/port > + description: Video port for LVDS Channel-A output (panel or bridge). > + > + properties: > + endpoint: > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > + description: LVDS Channel-A output endpoint > + unevaluatedProperties: false No need for 'endpoint' unless you have extra properties in it. > + > + port@3: > + $ref: /schemas/graph.yaml#/properties/port > + description: Video port for LVDS Channel-A output (panel or bridge). > + > + properties: > + endpoint: > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > + description: LVDS Channel-B output endpoint > + unevaluatedProperties: false Ditto > + > + required: > + - port@0 > + - port@2 > + > +required: > + - compatible > + - reg > + - enable-gpios > + - ports > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: ti,sn65dsi83 > + then: > + properties: > + ports: > + properties: > + port@1: false > + port@3: false > + > + - if: > + properties: > + compatible: > + contains: > + const: ti,sn65dsi84 > + then: > + properties: > + ports: > + properties: > + port@1: false > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + bridge@2d { > + compatible = "ti,sn65dsi83"; > + reg = <0x2d>; > + > + enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + endpoint { > + remote-endpoint = <&dsi0_out>; > + data-lanes = <1 2 3 4>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + > + endpoint { > + remote-endpoint = <&panel_in_lvds>; > + }; > + }; > + }; > + }; > + }; > -- > 2.30.2 >
