Re: [PATCH v2] drm: log errors in drm_gem_fb_init_with_funcs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, May 5th, 2021 at 2:14 AM, Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx> wrote:

> > As Ville said, if things got this far and the format is unsupported, something
> > must be going wrong. I'm not confident enough to switch this to a WARN_ON,
> > though.
>
> Hi Simon, thanks for your explanation.
>
> Is it common to get "!info" equal true? If not, and imho, I think that
> WARN_ON would be good to raise attention to a possible issue.

Maybe, but:

- I don't know enough to tell.
- Should be a separate patch anyway if we want to go with this, so that
  the WARN_ON can easily be reverted if need be (without reverting the
  logging additions).
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux