Re: [PATCH 1/1] drm/vmwgfx: free ttm resource before assigning a new one

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/3/21 7:39 PM, Christian König wrote:
Am 03.05.21 um 19:26 schrieb Nirmoy Das:
TTM BO resource need to be freed before calling ttm_bo_assign_mem().

Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxx>
---
  drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
index 2dc031fe4a90..93e4cf34a3a3 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
@@ -738,6 +738,7 @@ static int vmw_move(struct ttm_buffer_object *bo,
        if (old_man->use_tt && new_man->use_tt) {
          if (bo->mem.mem_type == TTM_PL_SYSTEM) {
+            ttm_resource_free(bo, &bo->mem);
              ttm_bo_assign_mem(bo, new_mem);

Mhm, we should probably rather call ttm_bo_move_null here like other drivers do.

Thanks Christian, I will send a updated patch.


Nirmoy


Christian.

              return 0;
          }

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux