On Thu, Apr 29, 2021 at 12:53:15PM -0400, Andrey Grodzovsky wrote: > On 2021-04-28 12:53 p.m., Bjorn Helgaas wrote: > > On Wed, Apr 28, 2021 at 11:11:48AM -0400, Andrey Grodzovsky wrote: > > > This is exact copy of 'USB: add support for dev_groups to > > > struct usb_device_driver' patch by Greg but just for > > > the PCI case. > > ... > > The usual commit citation format is 7d9c1d2f7aca ("USB: add support > > for dev_groups to struct usb_device_driver") so it's easier to locate > > the commit. > > > > I see there is also b71b283e3d6d ("USB: add support for dev_groups to > > struct usb_driver"). I don't know enough about USB to know whether > > 7d9c1d2f7aca or b71b283e3d6d is a closer analogue to what you're doing > > here, but I do see that struct usb_driver is far more common than > > struct usb_device_driver. > > > > PCI has struct pci_driver, but doesn't have the concept of a struct > > pci_device_driver. > > Since we don't have pci_device_driver then pci_driver is the best place > for it then, no ? Of course. My point was just that maybe you should say this is similar to b71b283e3d6d ("USB: add support for dev_groups to struct usb_driver"), not similar to 7d9c1d2f7aca ("USB: add support for dev_groups to struct usb_device_driver"). Bjorn _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel