Re: [PATCH] drm/i915/gem: Remove reference to struct drm_device.pdev

[Thomas Zimmermann <tzimmermann@xxxxxxx>]

Am 27.04.21 um 16:39 schrieb Ruhl, Michael J:
> > -----Original Message-----
> > From: dri-devel <dri-devel-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of
> > Thomas Zimmermann
> > Sent: Tuesday, April 27, 2021 7:08 AM
> > To: jani.nikula@xxxxxxxxxxxxxxx; joonas.lahtinen@xxxxxxxxxxxxxxx; Vivi, Rodrigo
> > <rodrigo.vivi@xxxxxxxxx>; airlied@xxxxxxxx; daniel@xxxxxxxx; Auld, Matthew
> > <matthew.auld@xxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>; Ursulin, Tvrtko
> > <tvrtko.ursulin@xxxxxxxxx>; Mika Kuoppala
> > <mika.kuoppala@xxxxxxxxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Gustavo
> > A. R. Silva <gustavoars@xxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Chris
> > Wilson <chris@xxxxxxxxxxxxxxxxxx>; Tang, CQ <cq.tang@xxxxxxxxx>; Hellstrom,
> > Thomas <thomas.hellstrom@xxxxxxxxx>; Thomas Zimmermann
> > <tzimmermann@xxxxxxx>; Daniel Vetter <daniel.vetter@xxxxxxxx>; Liu,
> > Xinyun <xinyun.liu@xxxxxxxxx>; Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Subject: [PATCH] drm/i915/gem: Remove reference to struct
> > drm_device.pdev
> >
> > References to struct drm_device.pdev should be used any longer as
>
> should not be used
>               ^^^
> ?

Oh, indeed.

> m
>
> > the field will be moved into the struct's legacy section. Add a fix
> > for the rsp commit.
> >
> > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > Fixes: d57d4a1daf5e ("drm/i915: Create stolen memory region from local
> > memory")
> > Cc: CQ Tang <cq.tang@xxxxxxxxx>
> > Cc: Matthew Auld <matthew.auld@xxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
> > Cc: Xinyun Liu <xinyun.liu@xxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> > Cc: "Thomas Hellström" <thomas.hellstrom@xxxxxxxxx>
> > Cc: "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>
> > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> > b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> > index c5b64b2400e8..e1a32672bbe8 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> > @@ -773,7 +773,7 @@ struct intel_memory_region *
> > i915_gem_stolen_lmem_setup(struct drm_i915_private *i915)
> > {
> > 	struct intel_uncore *uncore = &i915->uncore;
> > -	struct pci_dev *pdev = i915->drm.pdev;
> > +	struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
> > 	struct intel_memory_region *mem;
> > 	resource_size_t io_start;
> > 	resource_size_t lmem_size;
> > --
> > 2.31.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel