Re: [PATCH v3 0/7] drm: Clean up mmap for TTM-based GEM drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patches #1-#4 are Reviewed-by: Christian König <christian.koenig@xxxxxxx>

One more comment on the vmw patches.

Regards,
Christian.

Am 16.04.21 um 15:31 schrieb Thomas Zimmermann:
Implement mmap via struct drm_gem_object_functions.mmap in amdgpu,
radeon and nouveau. This allows for using common DRM helpers for
the mmap-related callbacks in struct file_operations and struct
drm_driver. The drivers have their own vm_ops, which are now set
automatically by the DRM core functions. The code in each driver's
verify_access becomes part of the driver's new mmap implementation.

With the GEM drivers converted, vmwgfx is the only user of
ttm_bo_mmap() and related infrastructure. So move everything into
vmwgfx and delete the rsp code from TTM.

This touches several drivers. Preferably everything would be merged
at once via drm-misc-next.

v3:
	* tidy up the new mmap functions in amdgpu and radeon (Christian)
v2:
	* removal of amdgpu fbdev mmap already merged (Christian)
	* rebase on top of amdgpu fixes [1] (Felix)
	* replace pr_err() with drm_err() in vmwgfx patch (Zack)
	* several typos

[1] https://patchwork.freedesktop.org/series/88822/

Thomas Zimmermann (7):
   drm/ttm: Don't override vm_ops callbacks, if set
   drm/amdgpu: Implement mmap as GEM object function
   drm/radeon: Implement mmap as GEM object function
   drm/nouveau: Implement mmap as GEM object function
   drm/vmwgfx: Inline ttm_bo_mmap() into vmwgfx driver
   drm/vmwgfx: Inline vmw_verify_access()
   drm/ttm: Remove ttm_bo_mmap() and friends

  drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 46 ---------------
  drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.h |  2 -
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c     |  4 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c     | 44 ++++++++++++++
  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c     | 64 --------------------
  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h     |  1 -
  drivers/gpu/drm/nouveau/nouveau_bo.c        | 10 ----
  drivers/gpu/drm/nouveau/nouveau_drm.c       |  3 +-
  drivers/gpu/drm/nouveau/nouveau_gem.c       | 36 ++++++++++++
  drivers/gpu/drm/nouveau/nouveau_ttm.c       | 49 ----------------
  drivers/gpu/drm/nouveau/nouveau_ttm.h       |  1 -
  drivers/gpu/drm/radeon/radeon_drv.c         |  3 +-
  drivers/gpu/drm/radeon/radeon_gem.c         | 49 ++++++++++++++++
  drivers/gpu/drm/radeon/radeon_ttm.c         | 65 ---------------------
  drivers/gpu/drm/radeon/radeon_ttm.h         |  1 -
  drivers/gpu/drm/ttm/ttm_bo_vm.c             | 60 ++-----------------
  drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c  |  9 ---
  drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c    | 53 ++++++++++++++++-
  include/drm/ttm/ttm_bo_api.h                | 13 -----
  include/drm/ttm/ttm_device.h                | 15 -----
  20 files changed, 191 insertions(+), 337 deletions(-)

--
2.31.1

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux