Hi Neil, Thank you for the patch. On Mon, Apr 12, 2021 at 05:46:46PM +0200, Neil Armstrong wrote: > From: Phong LE <ple@xxxxxxxxxxxx> > > Add the ITE bridge HDMI it66121 bindings. > > Signed-off-by: Phong LE <ple@xxxxxxxxxxxx> > Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > --- > .../bindings/display/bridge/ite,it66121.yaml | 123 ++++++++++++++++++ > 1 file changed, 123 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > new file mode 100644 > index 000000000000..61ed6dc7740b > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > @@ -0,0 +1,123 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/ite,it66121.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ITE it66121 HDMI bridge Device Tree Bindings > + > +maintainers: > + - Phong LE <ple@xxxxxxxxxxxx> > + - Neil Armstrong <narmstrong@xxxxxxxxxxxx> > + > +description: | > + The IT66121 is a high-performance and low-power single channel HDMI > + transmitter, fully compliant with HDMI 1.3a, HDCP 1.2 and backward compatible > + to DVI 1.0 specifications. > + > +properties: > + compatible: > + const: ite,it66121 > + > + reg: > + maxItems: 1 > + description: base I2C address of the device You can drop the description. > + > + reset-gpios: > + maxItems: 1 > + description: GPIO connected to active low reset > + > + vrf12-supply: > + description: Regulator for 1.2V analog core power. > + > + vcn33-supply: > + description: Regulator for 3.3V digital core power. > + > + vcn18-supply: > + description: Regulator for 1.8V IO core power. > + > + interrupts: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: DPI input port. > + > + properties: > + endpoint: > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > + unevaluatedProperties: false > + > + properties: > + bus-width: > + description: > + Endpoint bus width. > + enum: > + - 12 # 12 data lines connected and dual-edge mode > + - 24 # 24 data lines connected and single-edge mode > + default: 24 > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: HDMI Connector port. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - reset-gpios > + - vrf12-supply > + - vcn33-supply > + - vcn18-supply > + - interrupts > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; It's customary to indent DT examples with 4 spaces. > + > + it66121hdmitx: it66121hdmitx@4c { > + compatible = "ite,it66121"; > + pinctrl-names = "default"; > + pinctrl-0 = <&ite_pins_default>; > + vcn33-supply = <&mt6358_vcn33_wifi_reg>; > + vcn18-supply = <&mt6358_vcn18_reg>; > + vrf12-supply = <&mt6358_vrf12_reg>; > + reset-gpios = <&pio 160 1 /* GPIO_ACTIVE_LOW */>; You can #include the necessary headers at the top of the example, and use GPIO_ACTIVE_LOW and IRQ_TYPE_LEVEL_LOW to replace the numerical values. Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > + interrupt-parent = <&pio>; > + interrupts = <4 8 /* IRQ_TYPE_LEVEL_LOW */>; > + reg = <0x4c>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + it66121_in: endpoint { > + bus-width = <12>; > + remote-endpoint = <&display_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + hdmi_conn_out: endpoint { > + remote-endpoint = <&hdmi_conn_in>; > + }; > + }; > + }; > + }; > + }; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
