Applied. Thanks! Alex On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao <bernard@xxxxxxxx> wrote: > > Fix patch check warning: > WARNING: suspect code indent for conditional statements (8, 17) > + if (obj && obj->use < 0) { > + DRM_ERROR("RAS ERROR: Unbalance obj(%s) use\n", obj->head.name); > > WARNING: braces {} are not necessary for single statement blocks > + if (obj && obj->use < 0) { > + DRM_ERROR("RAS ERROR: Unbalance obj(%s) use\n", obj->head.name); > + } > > Signed-off-by: Bernard Zhao <bernard@xxxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > index 1fb2a91ad30a..43d17b72c265 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > @@ -449,11 +449,10 @@ static ssize_t amdgpu_ras_sysfs_read(struct device *dev, > > static inline void put_obj(struct ras_manager *obj) > { > - if (obj && --obj->use == 0) > + if (obj && (--obj->use == 0)) > list_del(&obj->node); > - if (obj && obj->use < 0) { > - DRM_ERROR("RAS ERROR: Unbalance obj(%s) use\n", obj->head.name); > - } > + if (obj && (obj->use < 0)) > + DRM_ERROR("RAS ERROR: Unbalance obj(%s) use\n", obj->head.name); > } > > /* make one obj and return it. */ > -- > 2.31.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel