Re: [PATCH v3 1/1] drm/bridge: lt8912b: Fix issues found during static analysis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le mer. 31 mars 2021 à 13:36, Dan Carpenter <dan.carpenter@xxxxxxxxxx> a écrit :
>
> On Wed, Mar 31, 2021 at 01:21:37PM +0200, Adrien Grassein wrote:
> > -     lt->data_lanes = of_property_count_u32_elems(endpoint, "data-lanes");
> > +     data_lanes = of_property_count_u32_elems(endpoint, "data-lanes");
> >       of_node_put(endpoint);
> > +     if (data_lanes < 0) {
> > +             dev_err(lt->dev, "%s: Bad data-lanes property\n", __func__);
> > +             return lt->data_lanes;
>
> This needs to be "return data_lanes;"
>
> > +     }
> > +     lt->data_lanes = data_lanes;
>
> I really believe that v4 will be the perfect version though...  :)
>
Ahah, maybe, let's see ^^.

> regards,
> dan carpenter
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux