Re: [PATCH] drm/vmwgfx: fix spinlock initialization in vmw_driver_load()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Mar 21, 2021, at 10:56, Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> Since vmw_write() from vmw_detect_version() from vmw_driver_load() calls
> spin_lock(&dev_priv->hw_lock), spin_lock_init(&dev_priv->hw_lock) has to
> be called before vmw_detect_version() is called, or lockdep gets disabled.
> 
>  INFO: trying to register non-static key.
>  the code is fine but needs lockdep annotation.
>  turning off the locking correctness validator.
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Fixes: 8772c0bb58bbf98a ("drm/vmwgfx: Cleanup pci resource allocation")

Thank you. I have a bit different version of this patch in my tree, I fixed it after Thomas noticed it last week but I was waiting for the pin/reserve discussion on the list to finish before pushing it. I apologize it took this long to get it upstreamed, I’ll get to it tomorrow. I’ll make sure to CC you on that series.

z

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux