Hi Maxime, Thank you for the patch. On Fri, Mar 19, 2021 at 04:29:20PM +0100, Maxime Ripard wrote: > Commit 977697e20b3d ("drm/atomic: Pass the full state to planes atomic > disable and update") added the old_state variable instead of what used > to be a parameter, but it also removed the sole user of that variable in > the vop_plane_atomic_update function leading to an usused variable. > Remove it. > > Fixes: 977697e20b3d ("drm/atomic: Pass the full state to planes atomic disable and update") > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 81c70d7a0471..64469439ddf2 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -879,8 +879,6 @@ static void vop_plane_atomic_disable(struct drm_plane *plane, > static void vop_plane_atomic_update(struct drm_plane *plane, > struct drm_atomic_state *state) > { > - struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state, > - plane); > struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, > plane); > struct drm_crtc *crtc = new_state->crtc; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel