Hi Doug,
On Mon, Mar 15, 2021 at 09:31:41AM -0700, Doug Anderson wrote:
> On Sat, Mar 13, 2021 at 1:13 PM Laurent Pinchart wrote:
> > On Thu, Mar 04, 2021 at 03:52:00PM -0800, Douglas Anderson wrote:
> > > This patch is _only_ code motion to prepare for the patch
> > > ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if
> > > refclk") and make it easier to understand.
> >
> > s/make/makes/
>
> I was never an expert at grammar, but I think either "make" or "makes"
> are fine. Simple version with parenthesis:
>
> Mine:
>
> This patch is <blah> to (prepare for the patch <blah>) and (make it
> easier to understand).
>
> Yours:
>
> This patch is <blah> (to prepare for the patch <blah>) and (makes it
> easier to understand).
>
> I suppose also valid would be:
>
> This patch is <blah> (to prepare for the patch <blah>) and (to make it
> easier to understand).
Your absolutely right. Both versions are fine, and your preferred
version is best :-)
> In any case if/when I spin this patch I'm fine changing it to your
> version just because (as I understand) it's equally valid and maybe
> looks slightly better?
>
> > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> Thanks for the reviews!
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
