Hi Liu, Thank you for the patch. On Wed, Mar 10, 2021 at 05:55:26PM +0800, Liu Ying wrote: > This patch adds documentations for RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, > RGB666_1X36_CPADLO and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp > pixel combiner. The RGB pixels with padding low per component are > transmitted on a 30-bit input bus(10-bit per component) from a display > controller or a 36-bit output bus(12-bit per component) to a pixel link. > > Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx> > Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > --- > v4->v5: > * Add Robert's R-b tag. > > v3->v4: > * No change. > > v2->v3: > * No change. > > v1->v2: > * No change. > > .../userspace-api/media/v4l/subdev-formats.rst | 156 +++++++++++++++++++++ > 1 file changed, 156 insertions(+) > > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst > index 7f16cbe..201c16d 100644 > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst > @@ -1488,6 +1488,80 @@ The following tables list existing packed RGB formats. > - b\ :sub:`2` > - b\ :sub:`1` > - b\ :sub:`0` > + * .. _MEDIA-BUS-FMT-RGB666-1X30-CPADLO: > + > + - MEDIA_BUS_FMT_RGB666_1X30-CPADLO > + - 0x101e > + - > + - 0 > + - 0 I count 32 bits here. Should these two 0 be replaced by spaces ? Same for MEDIA_BUS_FMT_RGB888_1X30-CPADLO. With this fixed, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + - 0 > + - 0 > + - 0 > + - 0 > + - g\ :sub:`5` > + - g\ :sub:`4` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - 0 > + - 0 > + - 0 > + - 0 > + - b\ :sub:`5` > + - b\ :sub:`4` > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - 0 > + - 0 > + - 0 > + - 0 > + * .. _MEDIA-BUS-FMT-RGB888-1X30-CPADLO: > + > + - MEDIA_BUS_FMT_RGB888_1X30-CPADLO > + - 0x101f > + - > + - 0 > + - 0 > + - r\ :sub:`7` > + - r\ :sub:`6` > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + - 0 > + - 0 > + - g\ :sub:`7` > + - g\ :sub:`6` > + - g\ :sub:`5` > + - g\ :sub:`4` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - 0 > + - 0 > + - b\ :sub:`7` > + - b\ :sub:`6` > + - b\ :sub:`5` > + - b\ :sub:`4` > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - 0 > + - 0 > * .. _MEDIA-BUS-FMT-ARGB888-1X32: > > - MEDIA_BUS_FMT_ARGB888_1X32 > @@ -1665,6 +1739,88 @@ The following table list existing packed 36bit wide RGB formats. > - 2 > - 1 > - 0 > + * .. _MEDIA-BUS-FMT-RGB666-1X36-CPADLO: > + > + - MEDIA_BUS_FMT_RGB666_1X36_CPADLO > + - 0x1020 > + - > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + - 0 > + - 0 > + - 0 > + - 0 > + - 0 > + - 0 > + - g\ :sub:`5` > + - g\ :sub:`4` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - 0 > + - 0 > + - 0 > + - 0 > + - 0 > + - 0 > + - b\ :sub:`5` > + - b\ :sub:`4` > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - 0 > + - 0 > + - 0 > + - 0 > + - 0 > + - 0 > + * .. _MEDIA-BUS-FMT-RGB888-1X36-CPADLO: > + > + - MEDIA_BUS_FMT_RGB888_1X36_CPADLO > + - 0x1021 > + - > + - r\ :sub:`7` > + - r\ :sub:`6` > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + - 0 > + - 0 > + - 0 > + - 0 > + - g\ :sub:`7` > + - g\ :sub:`6` > + - g\ :sub:`5` > + - g\ :sub:`4` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - 0 > + - 0 > + - 0 > + - 0 > + - b\ :sub:`7` > + - b\ :sub:`6` > + - b\ :sub:`5` > + - b\ :sub:`4` > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - 0 > + - 0 > + - 0 > + - 0 > * .. _MEDIA-BUS-FMT-RGB121212-1X36: > > - MEDIA_BUS_FMT_RGB121212_1X36 -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
