On Mon, Feb 15, 2021 at 05:38:16PM +0530, Jagan Teki wrote: > On Mon, Feb 15, 2021 at 5:28 PM Robert Foss <robert.foss@xxxxxxxxxx> wrote: > > > > Hey Jagan, > > > > Thanks for submitting this. > > > > checkpatch.pl threw some typ-o warnings, and I listed them below. I > > think either spelling is correct, but 'spelling.txt' does list this as > > a typ-o explicitly, so I would suggest conforming to that just to > > silence the checkpatch warning. > > > > This patch also passes 'dt_binding_check' and 'dtbs_check', but I > > think I'd like to defer to Rob Herring for an actual r-b. > > > > On Sun, 14 Feb 2021 at 18:55, Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > > > It has a flexible configuration of MIPI DSI signal input and > > > produce RGB565, RGB666, RGB888 output format. > > > > > > Add dt-bingings for it. > > > > > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > > --- > > > Changes for v3: > > > - updated to new dt-bindings style > > > > > > .../display/bridge/chipone,icn6211.yaml | 90 +++++++++++++++++++ > > > 1 file changed, 90 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > new file mode 100644 > > > index 000000000000..13764f13fe46 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > @@ -0,0 +1,90 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > > > $ scripts/checkpatch.pl --git HEAD~0 > > WARNING: 'Convertor' may be misspelled - perhaps 'Converter'? > > Thanks for pointing it. > > I was aware of it before sending it and need to understand whether we > need to use vendor naming conversion or not. Chipone call these > devices are Convertor [1], So I have used the vendor notation for > better understanding. > > Any comments are this would be welcome? Fix their spelling. If you need to propagate spelling/grammar errors, there's a defined way to do so. Rob > > [1] http://en.chiponeic.com/content/details45_123.html > > Jagan. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel