On Thu, Mar 4, 2021 at 2:57 AM Nicolas Boichat <drinkcat@xxxxxxxxxxxx> wrote:
> On Thu, Mar 4, 2021 at 8:41 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> >
> > A recent patch renaming MIPI_DSI_MODE_EOT_PACKET to
> > MIPI_DSI_MODE_NO_EOT_PACKET brought to light the
> > misunderstanding in the current MCDE driver and all
> > its associated panel drivers that MIPI_DSI_MODE_EOT_PACKET
> > would mean "use EOT packet" when in fact it means the
> > reverse.
> >
> > Fix it up by implementing the flag right in the MCDE
> > DSI driver and remove the flag from panels that actually
> > want the EOT packet.
> >
> > Suggested-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Reviewed-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
>
> I wonder if it's worth adding the fixes, should be:
>
> Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> Fixes: 899f24ed8d3a ("drm/panel: Add driver for Novatek NT35510-based panels")
> Fixes: ac1d6d74884e ("drm/panel: Add driver for Samsung S6D16D0 panel")
> Fixes: 435e06c06cb2 ("drm/panel: s6e63m0: Add DSI transport")
> Fixes: 8152c2bfd780 ("drm/panel: Add driver for Sony ACX424AKP panel")
>
> But then you'd almost need to separate the patches in multiple bits
> (these patches landed in very different releases).
>
> I'll leave that up to the maintainers to decide: this would only
> matter if anybody tried to use these panels on LTS releases with a
> non-MCDE driver (or MCDE with other panels).
It's not even a regression until someone else starts to use these panel
drivers (currently noone does), so I'd say let's just apply this and then
rebase and apply your cleanup on top.
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
