Hi, Thanks for the review! On 2/12/21 8:13 AM, Thomas Zimmermann wrote: > thanks for the driver. I only have some minor comments > > Am 11.02.21 um 10:50 schrieb Daniel Mack: >> +#define ILI9163_MADCTL_BGR BIT(3) >> +#define ILI9163_MADCTL_MV BIT(5) >> +#define ILI9163_MADCTL_MX BIT(6) >> +#define ILI9163_MADCTL_MY BIT(7) > > The indention is inconsistent. Or maybe it's just my email client. Yes, the latter :) Addressed the rest of your remarks. Will send a v2. Thanks, Daniel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel