|
[AMD Official Use Only - Internal Distribution Only] thanks comments.
I will refine these patches, then send out review later.
Best Regards,
Kevin
From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx>
Sent: Thursday, January 28, 2021 3:46 PM To: Wang, Kevin(Yang) <Kevin1.Wang@xxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx> Subject: Re: [RFC PATCH 0/3] add ttm trace event support Not a bad start, but that needs quite some more work.
First of all please rebase on top of current drm-misc-next, a whole bunch of the stuff you want to trace here was already removed or is about to be removed. Then concentrate on the necessary trace points, for example ttm:ttm_bo_device_init/release are overkill. On the other hand I'm missing important events like pool shrink, tt swapout/swapin (ttm_bo_swapout can be dropped) and especially BO init. I would separate the patches into one for each trace point. Not a must have, but it could make it easier to review and we can discuss for each one separately. Thanks, Christian. Am 28.01.21 um 08:13 schrieb Kevin Wang: > the kernel ftrace can better help analyze the kernel running status. > add some trace events to support TTM. > > add trace events list: > > ttm:ttm_bo_add_mem_to_lru > ttm:ttm_bo_del_from_lru > ttm:ttm_bo_move_mem > ttm:ttm_bo_wait > ttm:ttm_bo_evict > ttm:ttm_bo_swapout > ttm:ttm_bo_device_init > ttm:ttm_bo_device_release > ttm:ttm_bo_init_reserved > ttm:ttm_bo_validate > ttm:ttm_bo_release > ttm:ttm_bo_mmap > ttm:ttm_bo_vm_fault > ttm:ttm_bo_vm_access > ttm:ttm_shrink > ttm:ttm_mem_global_reserve > ttm:ttm_mem_global_free > > Kevin Wang (3): > drm/ttm: add ttm bo trace event support > drm/ttm: add ttm vm bo trace event support > drm/ttm: add ttm mem trace event support > > drivers/gpu/drm/ttm/ttm_bo.c | 23 ++ > drivers/gpu/drm/ttm/ttm_bo_vm.c | 12 +- > drivers/gpu/drm/ttm/ttm_memory.c | 7 + > drivers/gpu/drm/ttm/ttm_module.c | 3 + > drivers/gpu/drm/ttm/ttm_trace.h | 469 +++++++++++++++++++++++++++++++ > 5 files changed, 512 insertions(+), 2 deletions(-) > create mode 100644 drivers/gpu/drm/ttm/ttm_trace.h > |
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
