Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu <yongqiang.niu@xxxxxxxxxxxx> > > Not all SoC has dither function in gamma module. > Add private data to control this function setting. Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx> > > Signed-off-by: Yongqiang Niu <yongqiang.niu@xxxxxxxxxxxx> > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> > --- > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c > index b5a499d7e472c..c98fe284265d0 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c > @@ -25,7 +25,7 @@ > #define LUT_10BIT_MASK 0x03ff > > struct mtk_disp_gamma_data { > - u32 reserved; > + bool has_dither; > }; > > /** > @@ -91,7 +91,8 @@ void mtk_gamma_config(struct device *dev, unsigned int w, > > mtk_ddp_write(cmdq_pkt, h << 16 | w, &gamma->cmdq_reg, gamma->regs, > DISP_GAMMA_SIZE); > - mtk_dither_set_common(gamma->regs, &gamma->cmdq_reg, bpc, DISP_GAMMA_CFG, cmdq_pkt); > + if (gamma->data && gamma->data->has_dither) > + mtk_dither_set_common(gamma->regs, &gamma->cmdq_reg, bpc, DISP_GAMMA_CFG, cmdq_pkt); > } > > void mtk_gamma_start(struct device *dev) > @@ -171,8 +172,13 @@ static int mtk_disp_gamma_remove(struct platform_device *pdev) > return 0; > } > > +static const struct mtk_disp_gamma_data mt8173_gamma_driver_data = { > + .has_dither = true, > +}; > + > static const struct of_device_id mtk_disp_gamma_driver_dt_match[] = { > - { .compatible = "mediatek,mt8173-disp-gamma"}, > + { .compatible = "mediatek,mt8173-disp-gamma", > + .data = &mt8173_gamma_driver_data}, > {}, > }; > MODULE_DEVICE_TABLE(of, mtk_disp_gamma_driver_dt_match); _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel