Hi, On Mon, Jan 11, 2021 at 2:16 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Thu, Dec 10, 2020 at 12:19 AM Shawn Guo <shawnguo@xxxxxxxxxx> wrote: > > > > From: Shawn Guo <shawn.guo@xxxxxxxxxx> > > > > It renames GPIO register bits to drop 'SN_' prefix, so that they are > > consistent to other definitions - prefixing register name with 'SN_' but > > not for bit fields. > > > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 26 +++++++++++++------------- > > 1 file changed, 13 insertions(+), 13 deletions(-) > > Sorry for taking so long to get back to this. I think it came into my > inbox at the same time as a pile of other things and then got lost. > Your change looks good to me. Sorry for being inconsistent when > adding those defines and thanks for fixing them! > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Hrm, I just caught up on more email and found that in: https://lore.kernel.org/r/20201210174338.kecryijwptzc2mi7@xxxxxxxxxxxxxx ...that Uwe would prefer to keep these bits what I have and change all the others. ;-) I don't have a strong opinion either way, but I definitely agree that it'd be better for all the defines to be consistent. If I had to arbitrarily make the decision one way or the other I'd probably land Shawn's patch but I certainly wouldn't object if we went Uwe's way either. :-P -Doug _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
