Re: [PATCH] drm/imx: dw_hdmi-imx: depend on OF to fix randconfig compile tests on x86_64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/6/21 9:30 AM, Philipp Zabel wrote:
> The i.MX6 HDMI driver uses of_drm_find_bridge() and thus cannot be built
> with CONFIG_OF disabled:
> 
>     ld: drivers/gpu/drm/imx/dw_hdmi-imx.o: in function `dw_hdmi_imx_probe':
>     dw_hdmi-imx.c:(.text+0x29f): undefined reference to `of_drm_find_bridge'
> 
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Fixes: c805ec7eb210 ("drm/imx: dw_hdmi-imx: move initialization into probe")
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested

Thanks.

> ---
>  drivers/gpu/drm/imx/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig
> index 73fe2bc5633c..b5fa0e45a839 100644
> --- a/drivers/gpu/drm/imx/Kconfig
> +++ b/drivers/gpu/drm/imx/Kconfig
> @@ -37,7 +37,7 @@ config DRM_IMX_LDB
>  config DRM_IMX_HDMI
>  	tristate "Freescale i.MX DRM HDMI"
>  	select DRM_DW_HDMI
> -	depends on DRM_IMX
> +	depends on DRM_IMX && OF
>  	help
>  	  Choose this if you want to use HDMI on i.MX6.
>  
> 


-- 
~Randy
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux