Re: [PATCH v2 4/8] drm/vmwgfx: Cleanup fifo mmio handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Zack,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-exynos/exynos-drm-next]
[also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip linus/master v5.11-rc2 next-20210104]
[cannot apply to tegra-drm/drm/tegra/for-next drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zack-Rusin/Misc-cleanups-and-fixes-for-vmwgfx/20210106-022755
base:   https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
config: i386-randconfig-a006-20210106 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/15c65b4940b46b333f5bd0ddd5377ca90250ef80
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zack-Rusin/Misc-cleanups-and-fixes-for-vmwgfx/20210106-022755
        git checkout 15c65b4940b46b333f5bd0ddd5377ca90250ef80
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:7,
                    from include/linux/kernel.h:16,
                    from arch/x86/include/asm/percpu.h:27,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/dma-mapping.h:7,
                    from drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:29:
   drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_driver_load':
>> include/linux/kern_levels.h:5:18: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
       5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
         |                  ^~~~~~
   include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
      14 | #define KERN_INFO KERN_SOH "6" /* informational */
         |                   ^~~~~~~~
   include/drm/drm_print.h:481:15: note: in expansion of macro 'KERN_INFO'
     481 |  printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__)
         |               ^~~~~
   include/drm/drm_print.h:484:2: note: in expansion of macro '_DRM_PRINTK'
     484 |  _DRM_PRINTK(, INFO, fmt, ##__VA_ARGS__)
         |  ^~~~~~~~~~~
   drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:800:2: note: in expansion of macro 'DRM_INFO'
     800 |  DRM_INFO("Maximum display memory size is %llu kiB\n",
         |  ^~~~~~~~
   drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:800:46: note: format string is defined here
     800 |  DRM_INFO("Maximum display memory size is %llu kiB\n",
         |                                           ~~~^
         |                                              |
         |                                              long long unsigned int
         |                                           %u
   In file included from include/linux/printk.h:7,
                    from include/linux/kernel.h:16,
                    from arch/x86/include/asm/percpu.h:27,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/dma-mapping.h:7,
                    from drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:29:
   include/linux/kern_levels.h:5:18: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
       5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
         |                  ^~~~~~
   include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
      14 | #define KERN_INFO KERN_SOH "6" /* informational */
         |                   ^~~~~~~~
   include/drm/drm_print.h:481:15: note: in expansion of macro 'KERN_INFO'
     481 |  printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__)
         |               ^~~~~
   include/drm/drm_print.h:484:2: note: in expansion of macro '_DRM_PRINTK'
     484 |  _DRM_PRINTK(, INFO, fmt, ##__VA_ARGS__)
         |  ^~~~~~~~~~~
   drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:802:2: note: in expansion of macro 'DRM_INFO'
     802 |  DRM_INFO("VRAM at 0x%08llx size is %llu kiB\n",
         |  ^~~~~~~~
   drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:802:27: note: format string is defined here
     802 |  DRM_INFO("VRAM at 0x%08llx size is %llu kiB\n",
         |                      ~~~~~^
         |                           |
         |                           long long unsigned int
         |                      %08x
   In file included from include/linux/printk.h:7,
                    from include/linux/kernel.h:16,
                    from arch/x86/include/asm/percpu.h:27,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/dma-mapping.h:7,
                    from drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:29:
   include/linux/kern_levels.h:5:18: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
       5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
         |                  ^~~~~~
   include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
      14 | #define KERN_INFO KERN_SOH "6" /* informational */
         |                   ^~~~~~~~
   include/drm/drm_print.h:481:15: note: in expansion of macro 'KERN_INFO'
     481 |  printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__)
         |               ^~~~~
   include/drm/drm_print.h:484:2: note: in expansion of macro '_DRM_PRINTK'
     484 |  _DRM_PRINTK(, INFO, fmt, ##__VA_ARGS__)
         |  ^~~~~~~~~~~
   drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:802:2: note: in expansion of macro 'DRM_INFO'
     802 |  DRM_INFO("VRAM at 0x%08llx size is %llu kiB\n",
         |  ^~~~~~~~
   drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:802:40: note: format string is defined here
     802 |  DRM_INFO("VRAM at 0x%08llx size is %llu kiB\n",
         |                                     ~~~^
         |                                        |
         |                                        long long unsigned int
         |                                     %u
   In file included from include/linux/printk.h:7,
                    from include/linux/kernel.h:16,
                    from arch/x86/include/asm/percpu.h:27,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/dma-mapping.h:7,
                    from drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:29:
   include/linux/kern_levels.h:5:18: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
       5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
         |                  ^~~~~~
   include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
      14 | #define KERN_INFO KERN_SOH "6" /* informational */
         |                   ^~~~~~~~
   include/drm/drm_print.h:481:15: note: in expansion of macro 'KERN_INFO'
     481 |  printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__)


vim +5 include/linux/kern_levels.h

314ba3520e513a Joe Perches 2012-07-30  4  
04d2c8c83d0e3a Joe Perches 2012-07-30 @5  #define KERN_SOH	"\001"		/* ASCII Start Of Header */
04d2c8c83d0e3a Joe Perches 2012-07-30  6  #define KERN_SOH_ASCII	'\001'
04d2c8c83d0e3a Joe Perches 2012-07-30  7  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux