|
[AMD Official Use Only - Internal Distribution Only]
++Siqueira.
Regards,
Bindu
From: Alex Deucher <alexdeucher@xxxxxxxxx>
Sent: Tuesday, December 29, 2020 10:07 AM To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>; Wentland, Harry <Harry.Wentland@xxxxxxx>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@xxxxxxx>; Wu, Hersen <hersenxs.wu@xxxxxxx> Cc: Dave Airlie <airlied@xxxxxxxxx>; Pavic, Josip <Josip.Pavic@xxxxxxx>; R, Bindu <Bindu.R@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Daniel Vetter <daniel.vetter@xxxxxxxx>; LKML <linux-kernel@xxxxxxxxxxxxxxx>; dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx> Subject: Re: [git pull] drm fixes for 5.11-rc1 On Thu, Dec 24, 2020 at 5:28 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Dec 23, 2020 at 6:29 PM Dave Airlie <airlied@xxxxxxxxx> wrote: > > > > Xmas eve pull request present. Just some fixes that trickled in this > > past week. Mostly amdgpu fixes, with a dma-buf/mips build fix and some > > misc komeda fixes. > > Well, I already pulled and pushed out my merge, but only noticed > afterwards that clang complains about this, and I think it's a real > bug: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_mpc.c:475:6: warning: > variable 'val' is used uninitialized whenever 'if' condition is > false [-Wsometimes-uninitialized] > > and it sure is true: the code literally does > > uint32_t val; > > if (opp_id < MAX_OPP && REG(MUX[opp_id])) > REG_GET(MUX[opp_id], MPC_OUT_MUX, &val); > > return val; > > so clearly 'val' isn't initialized if that if-statement isn't true. > > I assume 'opp_id' is always presumed to be valid, but that code really > is disgusting. > > Just make it return 0 (or whatever) for invalid, possibly together > with a WARN_ON_ONCE(). Ok? Harry, Nick, Hersen, Can you take a look? Thanks, Alex > > Linus > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://nam11.safelinks.protection.outlook.com/?url=""> |
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
