Re: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Chenyang,


Am 23.12.20 um 02:19 schrieb Chenyang Li:
In line 24 "_AMDGPU_TRACE_H" is missing an underscore.

Nice catch. Could you please update the commit message summary, by adding a space after the prefix (colon), and using imperative mood [1]?

drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition

If you can also add a Fixes tag, that would be even better.

Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")

Signed-off-by: Chenyang Li <lichenyang@xxxxxxxxxxx>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

[…]


Kind regards,

Paul


[1]: https://chris.beams.io/posts/git-commit/
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux