On Tue, 2020-12-08 at 09:34 +0100, Frieder Schrempf wrote:
> Hi Maxime,
>
> On 03.12.20 14:25, Maxime Ripard wrote:
> > From: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> >
> > The DSI1_PHY_AFEC0_PD_DLANE1 and DSI1_PHY_AFEC0_PD_DLANE3 register
> > definitions were swapped, so trying to use more than a single data
> > lane failed as lane 1 would get powered down.
> > (In theory a 4 lane device would work as all lanes would remain
> > powered).
> >
> > Correct the definitions.
> >
> > Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
>
> Wouldn't this deserve a "Fixes: ..." and "Cc: stable@xxxxxxxxxxxxxxx"
> tag, as this bug is present in all stable releases since this driver was
> introduced? I think it would be really helpful to have it backported.
Agree, this would be nice:
Fixes: 4078f5757144 ("drm/vc4: Add DSI driver")
With that,
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
Regards,
Nicolas
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
