Hi Daniel, On 09/12/2020 02:51, Daniel Vetter wrote: >>> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h >>> index ba839e5e357d..4d9e217e5040 100644 >>> --- a/include/drm/drm_crtc.h >>> +++ b/include/drm/drm_crtc.h >>> @@ -1084,6 +1084,9 @@ struct drm_crtc { >>> */ >>> uint16_t *gamma_store; >>> >>> + bool has_gamma_prop : 1; >>> + bool has_degamma_prop : 1; > > I'm a bit behind on patches, but in case this got missed please remove > this and replace with the (obj, prop) lookup function thing or something > like that. Makes sure everything stays in sync, plus like I said atomic > uses this a ton. So not a problem here. The drm_mode_obj_find_prop_id() is in core drm.ko, and not exported, but I need it also from drm_kms_helper.ko. drm_mode_obj_find_prop_id() is declared in drm_crtc_internal.h. Are those functions supposed to be not exported from drm.ko? So, is it fine to just export drm_mode_obj_find_prop_id? If I export, should I move it to drm_mode_object.h? Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel