Re: [PATCH] drm: panel: add flags to BOE NV110WTM-N61

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Nov 30, 2020 at 10:26 AM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
>
> When applying a patch to add the BOE NV110WTM-N61 panel I forgot
> to add the changes that added flags to drm_display_mode.

Sorry, I didn't mean to make more work for you!


> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Fixes: a96ee0f6b58d ("drm: panel: simple: Add BOE NV110WTM-N61")
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 216cde33b5c4..2d093b5a513c 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1367,6 +1367,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
>                 .vsync_start = 800 + 3,
>                 .vsync_end = 800 + 3 + 5,
>                 .vtotal = 800 + 3 + 5 + 24,
> +               .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
>         },
>         {
>                 .clock = 57500,
> @@ -1378,6 +1379,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
>                 .vsync_start = 800 + 3,
>                 .vsync_end = 800 + 3 + 5,
>                 .vtotal = 800 + 3 + 5 + 24,
> +               .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,

I think you're off by 10 and a letter.

The subject talks about:
  NV110WTM-N61

You're modifying the structs for:
  NV101WXM-N51

I'm happy to post this if it's helpful to you, or I can review a v2
from you.  :-)

-Doug
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux