On Fri, 27 Nov 2020, Matthew Auld <matthew.auld@xxxxxxxxx> wrote: > + /* Enables Local Memory functionality in GAM */ > + I915_WRITE(GEN12_LMEM_CFG_ADDR, I915_READ(GEN12_LMEM_CFG_ADDR) | LMEM_ENABLE); Please use intel_uncore_read/write and intel_de_read/write throughout the series. We don't want any new users of I915_READ/I915_WRITE in the driver. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel