Re: [PATCH v4 20/21] drm/tegra: Implement job submission part of new UAPI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mikko,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tegra/for-next]
[also build test WARNING on linus/master v5.10-rc5]
[cannot apply to tegra-drm/drm/tegra/for-next next-20201124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mikko-Perttunen/Host1x-TegraDRM-UAPI/20201120-192927
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm-randconfig-r036-20201124 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project df9ae5992889560a8f3c6760b54d5051b47c7bf5)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/d5a3a653d37f5c7e8dfda77be51cc68ed7192b70
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mikko-Perttunen/Host1x-TegraDRM-UAPI/20201120-192927
        git checkout d5a3a653d37f5c7e8dfda77be51cc68ed7192b70
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/tegra/uapi/submit.c:114:18: warning: shift count >= width of type [-Wshift-count-overflow]
                   written_ptr |= BIT(39);
                                  ^~~~~~~
   include/vdso/bits.h:7:26: note: expanded from macro 'BIT'
   #define BIT(nr)                 (UL(1) << (nr))
                                          ^  ~~~~
   1 warning generated.

vim +114 drivers/gpu/drm/tegra/uapi/submit.c

   104	
   105	static int submit_write_reloc(struct gather_bo *bo,
   106				      struct drm_tegra_submit_buf *buf,
   107				      struct tegra_drm_mapping *mapping)
   108	{
   109		/* TODO check that target_offset is within bounds */
   110		dma_addr_t iova = mapping->iova + buf->reloc.target_offset;
   111		u32 written_ptr = (u32)(iova >> buf->reloc.shift);
   112	
   113		if (buf->flags & DRM_TEGRA_SUBMIT_BUF_RELOC_BLOCKLINEAR)
 > 114			written_ptr |= BIT(39);
   115	
   116		if (buf->reloc.gather_offset_words >= bo->gather_data_words)
   117			return -EINVAL;
   118	
   119		buf->reloc.gather_offset_words = array_index_nospec(
   120			buf->reloc.gather_offset_words, bo->gather_data_words);
   121	
   122		bo->gather_data[buf->reloc.gather_offset_words] = written_ptr;
   123	
   124		return 0;
   125	}
   126	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux